[libvirt] [PATCH] virsh-volume: Unify alignment of vol-list output columns
Daniel P. Berrange
berrange at redhat.com
Tue Nov 12 14:35:19 UTC 2013
On Tue, Nov 12, 2013 at 03:16:53PM +0100, Peter Krempa wrote:
> Add an extra space before the first column as we have when listing
> domains.
>
> Previous output:
>
> $ virsh vol-list glusterpool
> Name Path
> -----------------------------------------
> asdf gluster://gluster-node-1/gv0/asdf
> c gluster://gluster-node-1/gv0/c
> cd gluster://gluster-node-1/gv0/cd
>
> $ virsh vol-list glusterpool --details
> Name Path Type Capacity Allocation
> ----------------------------------------------------------------------
> asdf gluster://gluster-node-1/gv0/asdf unknown 0.00 B 0.00 B
> c gluster://gluster-node-1/gv0/c unknown 16.00 B 16.00 B
> cd gluster://gluster-node-1/gv0/cd unknown 0.00 B 0.00 B
>
> New output:
>
> $ virsh vol-list glusterpool
> Name Path
> ------------------------------------------------------------------------------
> asdf gluster://gluster-node-1/gv0/asdf
> c gluster://gluster-node-1/gv0/c
> cd gluster://gluster-node-1/gv0/cd
>
> $ virsh vol-list glusterpool --details
> Name Path Type Capacity Allocation
> ------------------------------------------------------------------------
> asdf gluster://gluster-node-1/gv0/asdf unknown 0.00 B 0.00 B
> c gluster://gluster-node-1/gv0/c unknown 16.00 B 16.00 B
> cd gluster://gluster-node-1/gv0/cd unknown 0.00 B 0.00 B
> ---
> tools/virsh-volume.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
ACK, this matches style used for 'virsh list'. Have you checked if any
other 'list' commands lack the leading space ?
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list