[libvirt] [PATCH 2/2] python: add error checking for calls to PyList_New
Giuseppe Scrivano
gscrivan at redhat.com
Tue Nov 12 17:18:20 UTC 2013
Eric Blake <eblake at redhat.com> writes:
> But the general observation remains - we have a lot of crufty code that
> does error handling incorrectly in our python bindings :) And there's
> still the question of whether we are going to split python bindings into
> their own repository; it might be nice to have the code cleaned up
> before that point.
I forgot to add that I have deliberately left the function
"libvirt_virConnectDomainEventGraphicsCallback" unchanged in my patch
(probably this should go in the commit message), that I prefer to
address later. It requires a bigger refactoring; from what I can see,
it expects things just to work.
Giuseppe
More information about the libvir-list
mailing list