[libvirt] [PATCH 3/6] virPCIDeviceBindToStub: Remove unused @oldDriverPath and @oldDriverName

Michal Privoznik mprivozn at redhat.com
Thu Nov 14 09:51:13 UTC 2013


These two chunks had to be part of df4283a55bf. But for some unclear
reason, the weren't. Anyway, these two variables are not used anywhere
within function. They're initialized to NULL and then VIR_FREE()-d. And
there's no reason do do two NOPs, right?

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/virpci.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/util/virpci.c b/src/util/virpci.c
index a41a22b..8a3a492 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -1085,8 +1085,6 @@ virPCIDeviceBindToStub(virPCIDevicePtr dev,
 
     char *stubDriverPath = NULL;
     char *driverLink = NULL;
-    char *oldDriverPath = NULL;
-    char *oldDriverName = NULL;
     char *path = NULL; /* reused for different purposes */
     const char *newDriverName = NULL;
 
@@ -1217,8 +1215,6 @@ remove_id:
 cleanup:
     VIR_FREE(stubDriverPath);
     VIR_FREE(driverLink);
-    VIR_FREE(oldDriverPath);
-    VIR_FREE(oldDriverName);
     VIR_FREE(path);
 
     if (newDriverName &&
-- 
1.8.3.2




More information about the libvir-list mailing list