[libvirt] [PATCH 4/6] virThreadPoolFree: Join worker threads

Daniel P. Berrange berrange at redhat.com
Thu Nov 14 14:16:24 UTC 2013


On Thu, Nov 14, 2013 at 07:13:43AM -0700, Eric Blake wrote:
> On 11/14/2013 02:51 AM, Michal Privoznik wrote:
> > Even though currently we are freeing the pool of worker threads at the
> > daemon very end, nothing holds us back in joining the worker threads.
> 
> Would it be better to detach the threads than to wait for them to join?

There's code earlier which uses a condition variable wait for them to
actually exit, so IIUC, joining them shouldn't add any delay.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list