[libvirt] [PATCH] Add hw random number generator (/dev/hwrng) to default qemu cgroup ACL

[Eric Blake]

On 11/18/2013 08:20 AM, Daniel P. Berrange wrote:

>>  static const char *const defaultDeviceACL[] = {
>>      "/dev/null", "/dev/full", "/dev/zero",
>> -    "/dev/random", "/dev/urandom",
>> +    "/dev/random", "/dev/urandom", "/dev/hwrng",
>>      "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
>>      "/dev/rtc", "/dev/hpet", "/dev/vfio/vfio",
>>      NULL,
> 
> NACK, for any device listed in the XML, we should add it in the per-VM
> cgroups setup code.
> 
> The existing /dev/random & /dev/urandom devices are there because they
> are used for basic crypto libraries unrelated to the XML config.

/dev/urandom, probably.  /dev/random - really?  Isn't that a DoS
potential for one guest to starve entropy from other guests, in spite of
sVirt?

> The
> /dev/hwrng device does not fall into this scenario.

Agreed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131118/0d41e31e/attachment-0001.sig>