[libvirt] [PATCH] qemuMonitorJSONGetCPUx86Data: Don't fail on ancient qemus

Michal Privoznik mprivozn at redhat.com
Tue Nov 19 15:30:14 UTC 2013


On 19.11.2013 15:53, Eric Blake wrote:
> On 11/19/2013 07:44 AM, Michal Privoznik wrote:
>> On the domain startup, this function is called to dump some info about
>> the CPUs. At the beginning of the function we check if we aren't running
>> older qemu which is not exposing the CPUs via 'qom-list'. However, we
>> are not checking for even older qemus, which throw 'CommandNotFound'
>> error.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>  src/qemu/qemu_monitor_json.c | 12 +++++++-----
>>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> Any chance we can enhance the testsuite to cover this?  At any rate, ACK.
> 
> 

I'll push this one, and post another patch adding a test case. Thanks!

Michal




More information about the libvir-list mailing list