[libvirt] [PATCH] Add missing break to switch-case block

Doug Goldstein cardoe at cardoe.com
Tue Nov 19 16:50:12 UTC 2013


On Tue, Nov 19, 2013 at 10:39 AM, Martin Kletzander <mkletzan at redhat.com> wrote:
> On Tue, Nov 19, 2013 at 10:32:01AM -0600, Doug Goldstein wrote:
>> The case label for VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED did not have its
>> own break statement but relied on falling through which we probably
>> don't want.
>> ---
>>  python/libvirt-override.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/python/libvirt-override.c b/python/libvirt-override.c
>> index 2e58bf9..747c877 100644
>> --- a/python/libvirt-override.c
>> +++ b/python/libvirt-override.c
>> @@ -6399,6 +6399,7 @@ libvirt_virConnectDomainEventRegisterAny(ATTRIBUTE_UNUSED PyObject * self,
>>          break;
>>      case VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED:
>>          cb = VIR_DOMAIN_EVENT_CALLBACK(libvirt_virConnectDomainEventDeviceRemovedCallback);
>> +        break;
>>
>>      case VIR_DOMAIN_EVENT_ID_LAST:
>>          break;
>> --
>> 1.8.3.2
>>
>
> ACK,
>
> Martin

Thanks. Pushed.

-- 
Doug Goldstein




More information about the libvir-list mailing list