[libvirt] [PATCH libvirt-python v3 34/40] virTypedParams* API appeared in 1.0.2 and used in 1.1.0

Daniel P. Berrange berrange at redhat.com
Fri Nov 22 16:22:58 UTC 2013


From: Doug Goldstein <cardoe at cardoe.com>

When building against versions of libvirt prior to 1.0.2, we can not
provide wrappers for virTypedParams* APIs. In addition we don't need
to have the helper APIs until 1.1.0 when the first API we wrap starts
to use them.
---
 libvirt-override.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libvirt-override.c b/libvirt-override.c
index dc04152..c345dfe 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -254,7 +254,9 @@ cleanup:
     return NULL;
 }
 
-
+/* While these appeared in libvirt in 1.0.2, we only
+ * need them in the python from 1.1.0 onwards */
+#if LIBVIR_CHECK_VERSION(1, 1, 0)
 typedef struct {
     const char *name;
     int type;
@@ -406,6 +408,7 @@ cleanup:
     virTypedParamsFree(params, n);
     return ret;
 }
+#endif /* LIBVIR_CHECK_VERSION(1, 1, 0) */
 
 
 /*
-- 
1.8.3.1




More information about the libvir-list mailing list