[libvirt] [PATCHv4 5/8] storage: improve directory support in gluster pool

[Daniel P. Berrange]

On Fri, Nov 22, 2013 at 08:20:27PM -0700, Eric Blake wrote:

> diff --git a/tests/storagevolxml2xmlin/vol-gluster-dir.xml b/tests/storagevolxml2xmlin/vol-gluster-dir.xml
> new file mode 100644
> index 0000000..bd20a6a
> --- /dev/null
> +++ b/tests/storagevolxml2xmlin/vol-gluster-dir.xml
> @@ -0,0 +1,13 @@
> +<volume>
> +  <name>dir</name>
> +  <key>/vol/dir</key>
> +  <source>
> +  </source>
> +  <type>network-dir</type>

Per my other reply I think that 'type' would be better as an attribute
on the top level <volume> element.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|