[libvirt] [PATCHv2] storage: expose volume meta-type in XML

Eric Blake eblake at redhat.com
Mon Nov 25 17:20:07 UTC 2013


On 11/25/2013 10:06 AM, Daniel P. Berrange wrote:
> On Mon, Nov 25, 2013 at 09:56:48AM -0700, Eric Blake wrote:
>> I got annoyed at having to use both 'virsh vol-list $pool --details'
>> AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated
>> the volume correctly.  Since two-thirds of the data present in
>> virStorageVolGetInfo() already appears in virStorageVolGetXMLDesc(),
>> this just adds the remaining piece of information, as:
>>
>> <volume type='...'>
>>   ...
>> </volume>
>>
>> * docs/formatstorage.html.in: Document new <volume type=...>.
>> * docs/schemas/storagevol.rng (vol): Add it to RelaxNG.
>> * src/conf/storage_conf.h (virStorageVolTypeToString): Declare.
>> * src/conf/storage_conf.c (virStorageVolTargetDefFormat): Output
>> the metatype.
>> (virStorageVolDefParseXML): Parse it, for unit tests.
>> * tests/storagevolxml2xmlout/vol-*.xml: Update tests to match.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
> 
> ACK

Thanks; will push shortly.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131125/520aeae3/attachment-0001.sig>


More information about the libvir-list mailing list