[libvirt] [PATCH python] Avoid generating the migrate methods in multiple classes

Eric Blake eblake at redhat.com
Tue Nov 26 20:00:38 UTC 2013


On 11/26/2013 10:00 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The python code generator tries to figure out what class a
> method should be in by looking at the list of arguments for
> any which are object types. Unfortunately missing break
> statements meant that methods which have multiple object
> arguments (eg migrate as a virDomainPtr followed by a
> virConnectPtr) got added to multiple classes. The migrate
> methods should only be visible in the virDomain class, and
> the versions in the virConnect class have fubar arguments.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  generator.py | 2 ++
>  1 file changed, 2 insertions(+)

ACK.  Wow - this repo split has forced us to address some long-standing
bugs.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131126/9de8c0e2/attachment-0001.sig>


More information about the libvir-list mailing list