[libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

[Daniel P. Berrange]

On Wed, Nov 27, 2013 at 03:08:18PM +0530, Nehal J Wani wrote:
> > The 'alias' attribute should *not* be parsed from the XML provided by
> > the user. It should only be parsed in the live state XML. In the latter
> > case no codepath should take us to qemuAssignDeviceAliases. So this is
> > certainly not the right fix. It sounds like the test case is flawed to
> > me.
> >
> Does the above hold true for qemuDomainAssignPCIAddresses as well?

No, it is valid for the user to set PCI addresses

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|