[libvirt] [PATCH] storage: skip selinux cleanup when fd not available

Eric Blake eblake at redhat.com
Wed Nov 27 13:25:46 UTC 2013


On 11/26/2013 11:43 PM, Osier Yang wrote:
> On 27/11/13 12:00, Eric Blake wrote:
>> When attempting to backport gluster pools to an older version
>> where there is no VIR_STRDUP, I got a crash from calling
>> strdup(,NULL).  Rather than relying on the current else branch
>> safely doing nothing when there is no fd, it is easier to just
>> skip it. While at it, there's no need to explicitly set
>> perms.label to NULL after a VIR_FREE().
>>
>> * src/storage/storage_backend.c
>> (virStorageBackendUpdateVolTargetInfoFD): Minor optimization.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---

> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131127/bbd00e4e/attachment-0001.sig>


More information about the libvir-list mailing list