[libvirt] [PATCH 1/3] Remove 'abs_srcdir' variable from test files

Eric Blake eblake at redhat.com
Wed Nov 27 22:17:51 UTC 2013


On 11/27/2013 09:31 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> Define 'abs_srcdir' in AM_CFLAGS, just as we do for 'abs_builddir'.
> This lets test files write code like
> 
>    abs_srcdir "/some/file"
> 
> and thus avoid the tedium of virAsprintf() to build paths in some
> places.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  tests/Makefile.am  |  1 +
>  tests/testutils.c  | 12 ------------
>  tests/testutils.h  |  1 -
>  tests/virpcimock.c |  5 -----
>  4 files changed, 1 insertion(+), 18 deletions(-)

Oh my.  I just independently implemented this and pushed it in an effort
to solve virpcitest failures!

NACK, on the grounds that it is obsolete :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131127/a7c13686/attachment-0001.sig>


More information about the libvir-list mailing list