[libvirt] [PATCH 1/3] add percentage limit parse and define support for RAM filesystems

[Chen Hanxiao]

> -----Original Message-----
> From: Daniel P. Berrange [mailto:berrange at redhat.com]
> Sent: Thursday, November 28, 2013 6:35 PM
> To: Chen Hanxiao
> Cc: libvir-list at redhat.com
> Subject: Re: [libvirt] [PATCH 1/3] add percentage limit parse and define support
> for RAM filesystems
> 
> On Thu, Nov 28, 2013 at 05:14:43PM +0800, Chen Hanxiao wrote:
> > From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> >
> > This patch enables percentage limit for ram filesystem
> >
> > <filesystem type='ram'>
> >     <source usage='10%'/>
> >     <target dir='/mnt'/>
> > </filesystem>
> >
> > Percentage limit would have more priority than size limit.
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> > ---
> >  src/conf/domain_conf.c | 21 +++++++++++++++++----
> >  src/conf/domain_conf.h |  1 +
> >  2 files changed, 18 insertions(+), 4 deletions(-)
> 
> I'm not really convinced we need this feature. Seems like more code for
> little real benefit.
> 

I think we should follow the style of mount(8). It accepted this style.

And this feature could bring us convenience in config, free us from counting the size. 

Thanks.

> Regards,
> Daniel
> --
> |: http://berrange.com      -o-
> http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-
> http://virt-manager.org :|
> |: http://autobuild.org       -o-
> http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-
> http://live.gnome.org/gtk-vnc :|