[libvirt] [PATCH] Fix memory leak in virNWFilterDefParseXML()

Nehal J Wani nehaljw.kkd1 at gmail.com
Fri Nov 29 15:10:31 UTC 2013


>
> I think it is preferrable to use virNWFilterEntryFree() here.
>
>>              if (entry->rule || entry->include) {
>
> Just following this line there is another call to VIR_FREE(entry)
> which leaks entry->rule and entry->include. This should be made
> to call virNWFilterEntryFree too
>
>

Would it be better to remove all the VIR_FREE(entry) and just put one
virNWFilterEntryFree(entry) below the label cleanup ?


-- 
Nehal J Wani




More information about the libvir-list mailing list