[libvirt] [PATCH 1/5] Don't set netdev offline in container cleanup

Daniel P. Berrange berrange at redhat.com
Wed Oct 2 11:31:16 UTC 2013


From: "Daniel P. Berrange" <berrange at redhat.com>

During container cleanup there is a race where the kernel may
have destroyed the veth device before we try to set it offline.
This causes log error messages. Given that we're about to
delete the device entirely, setting it offline is pointless.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 src/lxc/lxc_process.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index f92c613..a78784e 100644
--- a/src/lxc/lxc_process.c
+++ b/src/lxc/lxc_process.c
@@ -193,7 +193,6 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver,
         virDomainNetDefPtr iface = vm->def->nets[i];
         vport = virDomainNetGetActualVirtPortProfile(iface);
         if (iface->ifname) {
-            ignore_value(virNetDevSetOnline(iface->ifname, false));
             if (vport &&
                 vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH)
                 ignore_value(virNetDevOpenvswitchRemovePort(
-- 
1.8.3.1




More information about the libvir-list mailing list