[libvirt] [PATCH 08/18] qemumonitorjsontest: Test qemuMonitorJSONGetBalloonInfo

Eric Blake eblake at redhat.com
Wed Oct 2 19:52:37 UTC 2013


On 10/02/2013 11:09 AM, Michal Privoznik wrote:
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/qemumonitorjsontest.c | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> +
> +    if (qemuMonitorJSONGetBalloonInfo(qemuMonitorTestGetMonitor(test), &currmem) < 0)
> +        goto cleanup;

I guess Dan is in favor of the direct calls, in which case this is fine
(I'd still rather go through the wrappers, so we can get rid of
duplication in qemu_monitor_json.h).  The rest of the test looks fine,
so I'm not going to hold up an improvement to the testsuite in favor of
a refactoring not yet done.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131002/b5fb7535/attachment-0001.sig>


More information about the libvir-list mailing list