[libvirt] [PATCH 06/18] qemumonitorjsontest: Test qemuMonitorJSONGetCPUInfo

Michal Privoznik mprivozn at redhat.com
Thu Oct 3 09:58:34 UTC 2013


On 02.10.2013 20:31, Eric Blake wrote:
> On 10/02/2013 11:09 AM, Michal Privoznik wrote:
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>  tests/qemumonitorjsontest.c | 77 +++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 77 insertions(+)
>>
>> +                               "        {"
>> +                               "            \"current\": false,"
>> +                               "            \"CPU\": 2,"
>> +                               "            \"pc\": -2130530478,"
>> +                               "            \"halted\": true,"
>> +                               "            \"thread_id\": 17624"
>> +                               "        },"
>> +                               "        {"
>> +                               "            \"current\": false,"
>> +                               "            \"CPU\": 3,"
>> +                               "            \"pc\": -2130530478,"
>> +                               "            \"halted\": true,"
>> +                               "            \"thread_id\": 17625"
>> +                               "        }"
> 
> In the past, we've had a bug report about the case when cpu ids returned
> by this command are not contiguous.  Should you try that here, to make
> sure we've handled it correctly?
> 

The issue was not in the monitor itself rather than in higher levels.
But it doesn't hurt adjusting some numbers neither.

Michal




More information about the libvir-list mailing list