[libvirt] [PATCH v2]lxc: do cleanup when failed to bind fs as read-only
Chen Hanxiao
chenhanxiao at cn.fujitsu.com
Mon Oct 7 01:09:59 UTC 2013
> -----Original Message-----
> From: Eric Blake [mailto:eblake at redhat.com]
> Sent: Tuesday, October 01, 2013 3:38 AM
> Cc: Chen Hanxiao; libvir-list at redhat.com
> Subject: Re: [libvirt] [PATCH v2]lxc: do cleanup when failed to bind fs as
> read-only
>
> On 09/30/2013 01:29 PM, Eric Blake wrote:
> > On 09/30/2013 03:06 AM, Chen Hanxiao wrote:
> >> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> >>
> >> We forgot to do cleanup when lxcContainerMountFSTmpfs
> >> failed to bind fs as read-only.
> >>
> >> v2: fix an indentation issue
>
> Oh, and a side note. Patch changelogs, such as this paragraph...
>
> >>
> >> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> >> ---
>
> ...belong here, after the ---, so that 'git am' won't make them part of
> the permanent git history. They're highly useful to reviewers, but not
> so much when revisiting the code a year from now when we don't care how
> many iterations it took to get to a final patch.
>
Thanks for your correction!
> >
> > ACK and pushed.
>
> so I amended before actually pushing.
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
More information about the libvir-list
mailing list