[libvirt] [PATCH 0/5] Fill qemucapabilitiesdata with some data
Michal Privoznik
mprivozn at redhat.com
Mon Oct 7 06:44:44 UTC 2013
On 07.10.2013 00:14, Doug Goldstein wrote:
> On Thu, Oct 3, 2013 at 9:12 AM, Eric Blake <eblake at redhat.com> wrote:
>> On 10/03/2013 07:25 AM, Michal Privoznik wrote:
>>> The actual patches are accessible at:
>>>
>>> git://gitorious.org/libvirt/michal-staging.git
>>>
>>> branch test_qemu_capabilities_data
>>>
>>> I'm not sending the actual patches as it's big junk of JSON qemu replies. The
>>> patches has from 35KiB to 59KiB. I don't want to overload the list.
>>>
>>> Michal Privoznik (5):
>>> qemucapabilitiesdata: Add qemu-1.2.2 data
>>> qemucapabilitiesdata: Add qemu-1.3.1 data
>>> qemucapabilitiesdata: Add qemu-1.4.2 data
>>> qemucapabilitiesdata: Add qemu-1.6.0 data
>>> qemucapabilitiesdata: Add qemu-1.6.50 data
>>
>> ACK series.
>>
>
> Does 1.6.50 make sense? That's QEMU upstream master.
>
In my opinion it does. As I stated somewhere, there is no relationship
between qemu version and its capabilities, since capabilities can be
turned on or off by passing some arguments to the ./configure script.
Hence the data files have this suffix (-1, -2, ..) which should
differentiate between such cases.
IOW - the test just checks if our capabilities code isn't broken. We can
look at the version field as bare file name.
Michal
More information about the libvir-list
mailing list