[libvirt] [virt-tools-list] [PATCH] build: fix linker error on FreeBSD

Eric Blake eblake at redhat.com
Tue Oct 8 18:30:40 UTC 2013


On 10/08/2013 12:22 PM, Giuseppe Scrivano wrote:
> Eric Blake writes:
>> On 10/08/2013 10:21 AM, Giuseppe Scrivano wrote:
>>> Commit 2d74822a9eb4856c7f5216bb92bcb76630660f72 renamed
>>> "freebsdNodeGetCPUCount" to "appleFreebsdNodeGetCPUCount", leaving one
>>> call to "freebsdNodeGetCPUCount".  Fix this other case.
>>
>> ACK, although it looks like you intended this to go to libvir-list (now
>> cc'd)
> 
> I should be more careful with my bash history...
> 
> What do you think about replacing completely this function with the
> "nproc" module in gnulib?

Go for it! Gnulib recently relicensed nproc at my request, because I had
that eventual conversion in mind, although I obviously haven't been able
to get to it myself.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131008/565cfde5/attachment-0001.sig>


More information about the libvir-list mailing list