[libvirt] [PATCH 2/2] VMware: Do version detection earlier

Doug Goldstein cardoe at cardoe.com
Thu Oct 10 18:44:43 UTC 2013


Do VMware version detection earlier as future patches will need the
version information to populate capabilities correctly.
---
 src/vmware/vmware_driver.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c
index 79954e0..0e7a37f 100644
--- a/src/vmware/vmware_driver.c
+++ b/src/vmware/vmware_driver.c
@@ -166,6 +166,9 @@ vmwareConnectOpen(virConnectPtr conn,
         goto cleanup;
     }
 
+    if (vmwareExtractVersion(driver) < 0)
+        goto cleanup;
+
     if (!(driver->domains = virDomainObjListNew()))
         goto cleanup;
 
@@ -178,9 +181,6 @@ vmwareConnectOpen(virConnectPtr conn,
     if (vmwareLoadDomains(driver) < 0)
         goto cleanup;
 
-    if (vmwareExtractVersion(driver) < 0)
-        goto cleanup;
-
     conn->privateData = driver;
 
     return VIR_DRV_OPEN_SUCCESS;
-- 
1.8.1.5




More information about the libvir-list mailing list