[libvirt] [PATCH] qemu: Introduce qemuDomainDefCheckABIStability

[Eric Blake]

On 10/10/2013 03:23 AM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=994364
> 
> Whenever we check for ABI stability, we have new xml (e.g. provided by
> user, or obtained from snapshot, whatever) which we compare to old xml
> and see if ABI won't break. However, if the new xml was produced via
> virDomainGetXMLDesc(..., VIR_DOMAIN_XML_MIGRATABLE) it lacks some
> devices, e.g. 'pci-root' controller. Hence, the ABI stability check
> fails even though it is stable. Moreover, we can't simply fix
> virDomainDefCheckABIStability because removing the correct devices is
> task for the driver. For instance, qemu driver wants to remove the usb
> controller too, while LXC driver doesn't. That's why we need special
> qemu wrapper over virDomainDefCheckABIStability which removes the
> correct devices from domain XML, produces MIGRATABLE xml and calls the
> check ABI stability function.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_domain.c    | 22 ++++++++++++++++++++++
>  src/qemu/qemu_domain.h    |  3 +++
>  src/qemu/qemu_driver.c    | 10 ++--------
>  src/qemu/qemu_migration.c |  4 ++--
>  4 files changed, 29 insertions(+), 10 deletions(-)

Yes, this will make life simpler for all callers.  ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131010/f962187b/attachment-0001.sig>