[libvirt] [PATCH]lxc: fix an improper comment in lxc_process

Osier Yang jyang at redhat.com
Mon Oct 14 07:34:02 UTC 2013


On 14/10/13 14:22, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>
> Fix an improper comment when libvirt has released all resources
> for lxc.
> Then original comment says "stopped" rather than "released".
>
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>   src/lxc/lxc_process.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
> index d07ff13..7746c9b 100644
> --- a/src/lxc/lxc_process.c
> +++ b/src/lxc/lxc_process.c
> @@ -217,7 +217,7 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver,
>       virSystemdTerminateMachine(vm->def->name, "lxc", true);
>   
>   
> -    /* now that we know it's stopped call the hook if present */

I see no problem here, given that "it" means the vm process here. It
might be better to have a comma after "stopped" though, with explicitly
pointing out what "it" stands for. I.e.

/* now that we know the vm process is stopped, call the hook if present */


Osier




More information about the libvir-list mailing list