[libvirt] [PATCH] esx: Fix floppy.fileName handling in the vmx file parser

[Daniel P. Berrange]

On Mon, Oct 14, 2013 at 12:39:09PM -0400, Geoff Hickey wrote:
> The vmx file parsing code was reporting errors when parsing floppy.fileName
> entries if the filename didn't end in .flp. There is no such restriction in
> ESX; even using the GUI to configure floppy filenames you can specify any
> arbitrary file with any extension.
> 
> Fix by changing the vmx parsing code so that it uses the floppy.fileType
> value to determine whether floppy.fileName refers to a block device or a
> regular file.
> 
> Also remove code that would have generated an error if no floppy.fileName
> was specified. This is not an error either.
> ---
>  src/vmx/vmx.c | 28 ++++------------------------
>  1 file changed, 4 insertions(+), 24 deletions(-)

Thanks for your contribution. We like to have unit tests to validate
correct handling of XML conversions. Could you add some data files to
validate these particular problems to tests/vmx2xmltest.c

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|