[libvirt] [PATCH 1/2]virsh: enable attatch-disk command option '--mode' accept two parameters

[Chen Hanxiao]

> -----Original Message-----
> From: Daniel P. Berrange [mailto:berrange at redhat.com]
> Sent: Tuesday, October 15, 2013 5:42 PM
> To: Chen Hanxiao
> Cc: libvir-list at redhat.com
> Subject: Re: [libvirt] [PATCH 1/2]virsh: enable attatch-disk command option
> '--mode' accept two parameters
> 
> On Tue, Oct 15, 2013 at 11:54:27AM +0800, Chen Hanxiao wrote:
> > From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> >
> > Current disk could accept both 'readonly' and 'shareable'
> > at the same time.
> > But '--mode' could only accept one parameter.
> >
> > This patch enables '--mode' accept parameters like examples below:
> >
> > virsh # attach-disk domain /home/1.img sdd --mode shareable,readonly
> 
> That does not make sense - these options are mutually
> exclusive. Anything 'readonly' is implicitly 'shareable'
> without 'shareable' being required.

Do you mean that we should erase all about parameter 'shareable'?
Not only '--shareable' but also in '--mode shareable'?
If we decided to keep readonly and shareable in '--mode', we had to deal with
accepting two parameters at the same command line.

> 
> Daniel
> --