[libvirt] [PATCHv2 15/23] qemu: Clean up check of maximum cpu count supported by a machine type

Peter Krempa pkrempa at redhat.com
Wed Oct 16 07:51:45 UTC 2013


On 10/15/13 15:33, Daniel P. Berrange wrote:
> On Tue, Oct 15, 2013 at 02:30:44PM +0200, Peter Krempa wrote:
>> Reword the error message and change formating to avoid exceeding 80
>> columns of text.
>> ---
>>  src/qemu/qemu_process.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>

...

> 
> To be honest I'm not really a fan of making these kind of changes.
> 
> IMHO 80 column limit is something that shouldn't be strictly
> enforced when it causes splitting of messages which are only
> marginally over.

I definitely agree. Splitting lines just due to this historic limitation
seemed strange to me especially when it hinders code readability
(especially in condition statements).

Dropping this patch.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131016/7c69dd9d/attachment-0001.sig>


More information about the libvir-list mailing list