[libvirt] [PATCH] Add support for SPICE SASL

[Christophe Fergeau]

On Thu, Oct 17, 2013 at 02:46:46PM +0100, Daniel P. Berrange wrote:
> On Thu, Oct 17, 2013 at 03:38:04PM +0200, Christophe Fergeau wrote:
> > This adds a spice_sasl boolean option to qemu.conf to mimic what is
> > donc for VNC SASL support.
> 
> This is a dup of what I've already posted, but not yet pushed
> 
> https://www.redhat.com/archives/libvir-list/2013-September/msg00319.html
> 
> Now I've remembered, I'll push it :-)

Ah indeed, ACK to your patch fwiw. Feel free to squash the additions I made
to tests/ in your patch.

> 
> > I did not add a spice_sasl_dir option as the corresponding
> > vnc_sasl_dir option sets a SASL_CONF_DIR environment variable, but
> > I could not find any reference to that variable in either QEMU or
> > cyrus-sasl, and Google was not helpful either.
> 
> It is in the 'sasl_getconfpath_t' man page
> 
>   DESCRIPTION
>        sasl_getconfpath_t is used if the application wishes to use a  different
>        location  for the SASL configuration files. If this callback is not used
>        SASL  will  either  use  the  location  in  the   environment   variable
>        SASL_CONF_PATH  (provided  we  are  not  SUID  or SGID) or /etc/sasl2 by
>        default.
> 
> except we typoed  s/PATH/DIR/ so I'll fix that :-)

Ah, I indeed have more hits with that name! :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131017/331c2e4d/attachment-0001.sig>