[libvirt] [PATCH 1/5]virsh: disable config readonly and shareable in virsh command

[Eric Blake]

On 10/21/2013 02:14 PM, Michal Privoznik wrote:
> On 18.10.2013 07:42, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>>
>> Daneil's suggestion about flag <shareable/> and <readonly/> as follow:

s/Daneil/Daniel/

>> - Exclusive read-write. This is the default
>> - Shared read-write. This is the <shareable/> flag
>> - Shared read-only. This is the <readonly/> flag
>>

>>  
>> -    if (vshCommandOptBool(cmd, "shareable"))
>> +    if (!mode && vshCommandOptBool(cmd, "shareable"))
>>          virBufferAddLit(&buf, "  <shareable/>\n");
>>  

>  
> -    if (vshCommandOptBool(cmd, "shareable"))
> +    if (vshCommandOptBool(cmd, "shareable")) {
> +        if (mode) {
> +            vshError(ctl, "%s", _("--shareable and --mode are mutually exclusive"));
> +            goto cleanup;
> +        }
>          virBufferAddLit(&buf, "  <shareable/>\n");
> +    }

I don't think either of these approaches are needed.  If you make
--shareable an undocumented alias of --mode=shareable, then the alias
handling code will already guarantee that only one of the two spellings
appears, and you don't have to do any screening here.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131022/160d3c48/attachment-0001.sig>