[libvirt] [PATCH] build: fix build of virt-login-shell on systems with older gnutls

Daniel P. Berrange berrange at redhat.com
Tue Oct 22 08:27:03 UTC 2013


On Mon, Oct 21, 2013 at 11:29:33PM -0600, Jim Fehlig wrote:
> On systems where gnutls uses libgcrypt, I'm seeing the following
> build failure
> 
> libvirt.c:314: error: variable 'virTLSThreadImpl' has initializer but incomplete type
> libvirt.c:319: error: 'GCRY_THREAD_OPTION_PTHREAD' undeclared here (not in a function)
> ...
> 
> Fix by undefining WITH_GNUTLS_GCRYPT in config-post.h
> 
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> ---
> 
> Although I'm more confident in this fix vs the previously reported
> virt-login-shell build failure, I'd still prefer an ACK before pushing.
> 
>  config-post.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/config-post.h b/config-post.h
> index d371e8c..8367200 100644
> --- a/config-post.h
> +++ b/config-post.h
> @@ -34,6 +34,7 @@
>  # undef WITH_CURL
>  # undef WITH_DTRACE_PROBES
>  # undef WITH_GNUTLS
> +# undef WITH_GNUTLS_GCRYPT
>  # undef WITH_MACVTAP
>  # undef WITH_NUMACTL
>  # undef WITH_SASL

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list