[libvirt] [PATCHv2 2/2] virsh: undocument --shareable (--mode already covers it)

[Chen Hanxiao]

> -----Original Message-----
> From: Eric Blake [mailto:eblake at redhat.com]
> Sent: Thursday, October 24, 2013 3:22 PM
> To: libvir-list at redhat.com
> Cc: chenhanxiao at cn.fujitsu.com
> Subject: [PATCHv2 2/2] virsh: undocument --shareable (--mode already covers
> it)
> 
> Commit e962a57 added 'attach-disk --shareable', even though we
> already had 'attach-disk --mode=shareable'.  Worse, if the user
> types 'attach-disk --mode=readonly --shareable', we create
> non-sensical XML.  The best solution is just to undocument the
> duplicate spelling, by having it fall back to the preferred
> spelling.
> 
> * tools/virsh-domain.c (cmdAttachDisk): Let alias handling fix our
> mistake in exposing a second spelling for an existing option.
> * tools/virsh.pod: Fix documentation.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  tools/virsh-domain.c | 11 ++++-------

ACK

Thanks!