[libvirt] [PATCH] storage: fix incorrect typedef

[Eric Blake]

On 10/29/2013 10:07 AM, Daniel P. Berrange wrote:
> On Tue, Oct 29, 2013 at 10:00:17AM -0600, Eric Blake wrote:
>> The rbd code had a confusing typedef ending in Ptr that was not
>> actually a pointer, which made the rest of the code harder to
>> read.  This fixes things to actually pass by pointer rather than
>> by copy.
>>
>> * src/storage/storage_backend_rbd.c (virStorageBackendStatePtr):
>> Fix typedef.
>> (virStorageBackendRBDOpenRADOSConn)
>> (virStorageBackendRBDCloseRADOSConn)
>> (volStorageBackendRBDRefreshVolInfo)
>> (virStorageBackendRBDRefreshPool, virStorageBackendRBDDeleteVol)
>> (virStorageBackendRBDCreateVol, virStorageBackendRBDRefreshVol)
>> (virStorageBackendRBDResizeVol): Fix fallout.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>
>> A quick git grep found no other instances of a '...Ptr' typedef
>> that wasn't actually a pointer; but I can also add a syntax check
>> to prevent that mistake if desired.

Coming up in a separate thread.

>>
>>  src/storage/storage_backend_rbd.c | 46 +++++++++++++++++++--------------------
>>  1 file changed, 23 insertions(+), 23 deletions(-)
> 
> ACK

Thanks; pushed.

> 
> Daniel
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131029/142a8098/attachment-0001.sig>