[libvirt] [PATCH] maint: avoid further typedef accidents

Ján Tomko jtomko at redhat.com
Wed Oct 30 08:24:43 UTC 2013


On 10/29/2013 09:04 PM, Eric Blake wrote:
> To make it easier to forbid future attempts at a confusing typedef
> name ending in Ptr that isn't actually a pointer, insist that we
> follow our preferred style of 'typedef foo *fooPtr'.
> 
> * cfg.mk (sc_forbid_const_pointer_typedef): Enforce consistent
> style, to prevent issue fixed in previous storage patch.
> * src/conf/capabilities.h (virCapsPtr): Fix offender.
> * src/security/security_stack.c (virSecurityStackItemPtr):
> Likewise.
> * tests/qemucapabilitiestest.c (testQemuDataPtr): Likewise.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  cfg.mk                        | 4 ++++
>  src/conf/capabilities.h       | 4 ++--
>  src/security/security_stack.c | 2 +-
>  tests/qemucapabilitiestest.c  | 2 +-
>  4 files changed, 8 insertions(+), 4 deletions(-)
> 

ACK

Jan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131030/225b8210/attachment-0001.sig>


More information about the libvir-list mailing list