[libvirt] [PATCH] qemu: fix well-formed migration URI formatting

Michael Chapman mike at very.puzzling.org
Thu Oct 31 01:26:59 UTC 2013


On Tue, 29 Oct 2013, Eric Blake wrote:
> Apologies for the slow review time.
>
> ACK and pushed.  A testsuite addition would also be nice, to prove we
> don't regress...

Thanks!

I did look into adding this to the testsuite, but as far as I can tell we 
don't have anything there yet that runs through the migration phases.

For a proper test I'm guessing we'd need to mock the QEMU binary itself, 
since the prepare phase wants to start it. I suppose it might be possible 
just to run through an offline migration, but as a migration URI makes no 
sense for offline migration it's not really a fair test.

- Michael




More information about the libvir-list mailing list