[libvirt] [PATCH] Fix race in starting transient VMs

[Eric Blake]

On 10/31/2013 01:00 PM, Eric Blake wrote:
> On 10/31/2013 12:41 PM, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange" <berrange at redhat.com>
>>
>> When starting a transient VM the first thing done is to check
>> for duplicates. The check looks if there are any running VMs
>> with the matching name/uuid. It explicitly allows there to
>> be inactive VMs, so that a persistent VM can be temporarily
>> booted with a different config.
>>
> 
>>
>> The fix is to only allow an existing inactive VM if it is
>> marked as persistent.
>>
>> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
>> ---
>>  src/conf/domain_conf.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
> 
> ACK.  What a nasty bug to track down.

If I'm correct, this bug is a regression from the time that we first
converted to no longer holding the driver lock around entire API calls
(commit a9e97e0, v1.0.3)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131031/3cdfdb32/attachment-0001.sig>