[libvirt] [PATCH 3/3] virsh-domain: Avoid killing ssh transport tunnels when cancelling job

Peter Krempa pkrempa at redhat.com
Tue Sep 3 08:03:43 UTC 2013


On 09/03/13 09:53, Michal Privoznik wrote:
> On 29.08.2013 17:52, Peter Krempa wrote:
>> The vshWatchJob function registers a SIGINT handler that is used to
>> abort the active job and does not terminate virsh. Unfortunately, this
>> breaks when using the ssh transport as SIGINT is sent to the foreground
>> process group including the ssh transport processes which terminate.
>> This breaks the connection and migration is left in a insane state.
>>
>> With this patch the terminal is modified to ignore key binding that
>> sends SIGINT and does the handling manually.
>>
>> Resoves: https://bugzilla.redhat.com/show_bug.cgi?id=983348
>> ---
>>  tools/virsh-domain.c | 45 ++++++++++++++++++++++++++++++++-------------
>>  1 file changed, 32 insertions(+), 13 deletions(-)
>>
> 
> ACK
> 
> Michal
> 

Thanks for the reviews, I've pushed 2/3 and 3/3 now.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130903/f100d7b2/attachment-0001.sig>


More information about the libvir-list mailing list