[libvirt] storage pool that contains thin LVs
Doug Goldstein
cardoe at gentoo.org
Fri Sep 20 04:36:32 UTC 2013
On Thu, Sep 19, 2013 at 10:34 PM, Dusty Mabe <dustymabe at gmail.com> wrote:
> Hey guys,
>
> Just looking at https://bugzilla.redhat.com/show_bug.cgi?id=924672 and
> looks like all we need to do is ignore thin pools and thin pool data
> devices. With some trivial testing this seems to work fine (i.e.
> failed before and works now).
>
>
> diff --git a/src/storage/storage_backend_logical.c
> b/src/storage/storage_backend_logical.c
> index a1a37a1..0154256 100644
> --- a/src/storage/storage_backend_logical.c
> +++ b/src/storage/storage_backend_logical.c
> @@ -85,6 +85,10 @@ virStorageBackendLogicalMakeVol(virStoragePoolObjPtr pool,
> if (attrs[4] != 'a')
> return 0;
>
> + /* Skip thin pools(t) and thin pool data(T) */
> + if (attrs[0] == 't' || attrs[0] == 'T')
> + return 0;
> +
> /* See if we're only looking for a specific volume */
> if (data != NULL) {
> vol = data;
>
> I'm sure the fix isn't this trivial but i can finish it up and submit
> an official patch (through git) if this is close.
>
> Dusty
Not yet sure of the correctness / completeness but I would go ahead
and submit a git commit and we can go from there.
--
Doug Goldstein
More information about the libvir-list
mailing list