[libvirt] [PATCH 01/10] Fix crash on OOM when parsing disk security label

Daniel P. Berrange berrange at redhat.com
Mon Sep 23 13:23:10 UTC 2013


From: "Daniel P. Berrange" <berrange at redhat.com>

If an OOM error occurs in virSecurityDeviceLabelDefParseXML the
cleanup code may free an uninitialized pointer, causing a crash

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 8953579..73ae0b0 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -4507,7 +4507,7 @@ virSecurityDeviceLabelDefParseXML(virSecurityDeviceLabelDefPtr **seclabels_rtn,
                                   int nvmSeclabels, xmlXPathContextPtr ctxt,
                                   unsigned int flags)
 {
-    virSecurityDeviceLabelDefPtr *seclabels;
+    virSecurityDeviceLabelDefPtr *seclabels = NULL;
     size_t nseclabels = 0;
     int n;
     size_t i, j;
-- 
1.8.3.1




More information about the libvir-list mailing list