[libvirt] [PATCH 1/2] test: fix call to virFDStreamOpenFile in testDomainScreenshot

Claudio Bley cbley at av-test.de
Tue Sep 24 09:57:37 UTC 2013


N.B.  This had no ill effects as long as O_RDONLY is defined to
      to be 0, such that the expression (O_RDONLY < 0) yielded 0
      again.

Signed-off-by: Claudio Bley <cbley at av-test.de>
---
 src/test/test_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 47c9d38..e1197c9 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -5862,7 +5862,7 @@ testDomainScreenshot(virDomainPtr dom ATTRIBUTE_UNUSED,
     if (VIR_STRDUP(ret, "image/png") < 0)
         return NULL;
 
-    if (virFDStreamOpenFile(st, PKGDATADIR "/libvirtLogo.png", 0, 0, O_RDONLY < 0))
+    if (virFDStreamOpenFile(st, PKGDATADIR "/libvirtLogo.png", 0, 0, O_RDONLY) < 0)
         VIR_FREE(ret);
 
     return ret;
-- 
1.8.3.1




More information about the libvir-list mailing list