[libvirt] [PATCH 3/6] qemu: replace multiple strcmps with a switch on an enum

Ján Tomko jtomko at redhat.com
Wed Sep 25 14:07:35 UTC 2013


On 09/25/2013 02:30 PM, Laine Stump wrote:
> I'm not sure why this code was written to compare the strings that it
> had just retrieved from an enum->string conversion, rather than just
> look at the original enum values, but this yields the same results,
> and is much more efficient (especially as you add more devices).
> 
> This is a prerequisite for patches to resolve:
> 
>    https://bugzilla.redhat.com/show_bug.cgi?id=1003983
> ---
>  src/qemu/qemu_command.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)

ACK

Jan




More information about the libvir-list mailing list