[libvirt] [PATCH] Fix leaks in python bindings

Ján Tomko jtomko at redhat.com
Tue Sep 3 11:19:53 UTC 2013


https://bugzilla.redhat.com/show_bug.cgi?id=1003828
---
 python/libvirt-lxc-override.c  | 1 +
 python/libvirt-qemu-override.c | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/python/libvirt-lxc-override.c b/python/libvirt-lxc-override.c
index fa7e963..f76ff4b 100644
--- a/python/libvirt-lxc-override.c
+++ b/python/libvirt-lxc-override.c
@@ -92,6 +92,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTRIBUTE_UNUSED,
             goto error;
         }
     }
+    VIR_FREE(fdlist);
     return py_retval;
 
 error:
diff --git a/python/libvirt-qemu-override.c b/python/libvirt-qemu-override.c
index 8f1ce5e..6249031 100644
--- a/python/libvirt-qemu-override.c
+++ b/python/libvirt-qemu-override.c
@@ -21,6 +21,7 @@
 #include <libvirt/virterror.h>
 #include "typewrappers.h"
 #include "libvirt-qemu.h"
+#include "viralloc.h"
 
 #ifndef __CYGWIN__
 extern void initlibvirtmod_qemu(void);
@@ -79,6 +80,7 @@ libvirt_qemu_virDomainQemuMonitorCommand(PyObject *self ATTRIBUTE_UNUSED,
         return VIR_PY_NONE;
 
     py_retval = PyString_FromString(result);
+    VIR_FREE(result);
     return py_retval;
 }
 
@@ -108,6 +110,7 @@ libvirt_qemu_virDomainQemuAgentCommand(PyObject *self ATTRIBUTE_UNUSED, PyObject
         return VIR_PY_NONE;
 
     py_retval = PyString_FromString(result);
+    VIR_FREE(result);
     return py_retval;
 }
 /************************************************************************
-- 
1.8.1.5




More information about the libvir-list mailing list