[libvirt] [PATCH 6/n] spec: make client-only testing easier

Michal Privoznik mprivozn at redhat.com
Thu Sep 5 07:51:51 UTC 2013


On 04.09.2013 23:08, Eric Blake wrote:
> Several recent patches cleaned up 'make rpm' for the situation
> when client_only is true; these were done by manual spec file
> editing (since it's relatively hard to come by a RHEL 5 s390
> box).  Make it easier to do in the future via a simpler command
> line override.
> 
> * libvirt.spec.in (client_only): Allow for override.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  libvirt.spec.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index e4b8329..a55e87c 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -13,12 +13,13 @@
>  # touch configure.ac or Makefile.am.
>  %{!?enable_autotools:%define enable_autotools 0}
> 
>  # A client only build will create a libvirt.so only containing
>  # the generic RPC driver, and test driver and no libvirtd
> -# Default to a full server + client build
> -%define client_only        0
> +# Default to a full server + client build, but with the possibility
> +# of a command-line or ~/.rpmmacros override for client-only.
> +%{!?client_only:%define client_only 0}
> 
>  # Now turn off server build in certain cases
> 
>  # RHEL-5 builds are client-only for s390, ppc
>  %if 0%{?rhel} == 5
> 

ACK

Michal




More information about the libvir-list mailing list