[libvirt] [PATCH] qemu: Remove unnecessary variable assignment

hw bi hwbi2008 at gmail.com
Fri Sep 6 07:02:25 UTC 2013


I understand. Thanks for your reminding.



2013/9/6 Ján Tomko <jtomko at redhat.com>

> On 09/06/2013 07:35 AM, Hongwei Bi wrote:
> > Remove unnecessary 'addrs = NULL' in
> > qemuDomainAssignS390Addresses() and
> > qemuDomainAssignPCIAddresses() due to
> > the related Free function in label cleanup.
>
> But it is necessary, because we assign the value of addrs to
> priv->ccwaddrs.
> If we didn't set addrs to NULL, it would get freed by that function in the
> cleanup: section and priv->ccwaddrs would point to freed memory.
>
> Jan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130906/b4ad64a0/attachment-0001.htm>


More information about the libvir-list mailing list