[libvirt] [PATCH libvirt-python 17/17] Setup distutils buld system
Eric Blake
eblake at redhat.com
Mon Sep 9 17:34:14 UTC 2013
On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Create a setup.py for building libvirt python code and add
> supporting files
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> .gitignore | 4 +
> AUTHORS.in | 12 ++
> COPYING | 339 +++++++++++++++++++++++++++++++++
> COPYING.LESSER | 502 +++++++++++++++++++++++++++++++++++++++++++++++++
> MANIFEST.in | 25 +++
> NEWS | 9 +
> autobuild.sh | 25 +++
> libvirt-python.spec.in | 34 ++++
> setup.py | 294 +++++++++++++++++++++++++++++
> 9 files changed, 1244 insertions(+)
> create mode 100644 .gitignore
> create mode 100644 AUTHORS.in
> create mode 100644 COPYING
> create mode 100644 COPYING.LESSER
> create mode 100644 MANIFEST.in
> create mode 100644 NEWS
> create mode 100755 autobuild.sh
> create mode 100644 libvirt-python.spec.in
> create mode 100644 setup.py
I'm not a setup.py expert, and this is more of a cursory review.
Overall, I like where the series is headed, but think we have some work
to do before actually doing the split.
> +++ b/.gitignore
> @@ -0,0 +1,4 @@
> +build/
> +dist/
> +MANIFEST
> +*~
> \ No newline at end of file
Whoops.
> diff --git a/AUTHORS.in b/AUTHORS.in
> new file mode 100644
> index 0000000..cee329e
> --- /dev/null
> +++ b/AUTHORS.in
> @@ -0,0 +1,12 @@
> + Libvirt Python Binding Authors
> + ==============================
> +
> +The libvirt python binding is maintained by the
> +libvirt development team, who can be contacted
> +at
Any reason this is wrapped
at such a narrow width? Three
lines feels a bit excessive.
> +++ b/NEWS
> @@ -0,0 +1,9 @@
> + Libvirt Python News
> + ===================
> +
> +
> +Release 1.1.2
> +=============
First release will be 1.1.3.
> diff --git a/setup.py b/setup.py
> new file mode 100644
Does this file need 'chmod +x'?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130909/6b20817d/attachment-0001.sig>
More information about the libvir-list
mailing list