[libvirt] [PATCHv2 RESEND] Add forwarders attribute to <dns /> element.

[Diego Woitasen]

On Wed, Sep 11, 2013 at 11:05 AM, Ján Tomko <jtomko at redhat.com> wrote:
> On 09/11/2013 03:36 PM, Laine Stump wrote:
>> On 09/10/2013 04:26 PM, Diego Woitasen wrote:
>>> Useful to set custom forwarders instead of using the contents of
>>> /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM
>>> domain names from domain 0, when domain option is used.
>>
>>
>> Dang! I had promised to look at this last week, then forgot :-(
>>
>>
>>>
>>>          <domain name="example.com"/>
>>>          <dns>
>>>            <txt name="example" value="example value" />
>>> +          <forwarders addr="8.8.8.8" />
>                                          --^
> Please remove this space as well, to be consistent with the other elements.

Are you talking about the space before" />"?

Gmail has moved you mark I think :)

>
> Jan
>
>>> +          <forwarders addr="8.8.4.4" />
>>
>>
>> In your earlier proposal, you had called this element "forward" rather
>> than "forwards". I think a singular name is better, since each element
>> is a single forwarding address.
>>
>



-- 
Diego Woitasen
VHGroup - Lead Linux and open source solutions architect
www.vhgroup.net