[libvirt] [PATCH 1/3] util: Declare that virFileExists shall honor errno
Peter Krempa
pkrempa at redhat.com
Mon Sep 16 09:31:22 UTC 2013
On 09/13/13 17:36, Eric Blake wrote:
> On 09/13/2013 08:19 AM, Peter Krempa wrote:
>> Explicitly state that some parts of the code may require virFileExists
>> to set or preserve a correct errno so that future modifications don't
>> break.
>> ---
>> src/util/virfile.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
...
>> +/**
>> + * virFileExists: Check for presence of file
>> + * @path: Path of file to check
>> + *
>> + * Returns wether file exists. Preserves errno in case it does not exist.
>
> s/wether/whether/
>
> or even:
>
> s/wether/true if the/
I chose this wording and ...
>
>> + */
>> bool
>> virFileExists(const char *path)
>> {
>>
>
> ACK once you avoid the typo.
>
... pushed this patch.
Thanks.
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130916/e1002f37/attachment-0001.sig>
More information about the libvir-list
mailing list