[libvirt] [PATCH 0/2]

Claudio Bley cbley at av-test.de
Tue Sep 24 09:57:36 UTC 2013


Hi.

I used the rawhide RPMs to take out the DLLs for a test drive on Windows 64bit
the other day.

While trying to read the "screenshot" from the test domain using the 
test:///default connection, I only received 5 Bytes of the libvirtLogo.png file.

Looking at the test driver, the condition piqued my interest, but wasn't the
cause of the short read, only a bit odd. See patch #1.

The actual cause was that the file was opened in text mode and the seventh byte
was a 0x1A which triggered EOF on the FD. See patch #2.

Claudio Bley (2):
  test: fix call to virFDStreamOpenFile in testDomainScreenshot
  Always open files in binary mode in virFDStreamOpenFileInternal

 src/fdstream.c         | 2 +-
 src/test/test_driver.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.8.3.1




More information about the libvir-list mailing list