[libvirt] [PATCH 2/2] Always open files in binary mode in virFDStreamOpenFileInternal
Daniel P. Berrange
berrange at redhat.com
Tue Sep 24 10:16:39 UTC 2013
On Tue, Sep 24, 2013 at 11:57:38AM +0200, Claudio Bley wrote:
> On win32, using text mode for binary files might result in short
> reads since ASCII character 0x1A is interpreted as EOF. Also, it
> could lead to problems using the seek functions because of the \r
> handling.
>
> Signed-off-by: Claudio Bley <cbley at av-test.de>
What did you do to hit this problem ? AFAIK the virFDStream code
isn't useful on Windows at all, since it requires the iohelper
process and we haven't got that working on Windows.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list