[libvirt] [PATCH] rpc: Increase bound limit for virDomainGetJobStats

Daniel P. Berrange berrange at redhat.com
Fri Sep 27 10:48:53 UTC 2013


On Fri, Sep 27, 2013 at 10:57:40AM +0200, Jiri Denemark wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1012818
> 
> Commit 6d7d0b1869ed293e3208d11f375cecea0129dfc5 (in 1.1.2) added bounds
> checking to virDomainGetJobStats. But even at that time the API was able
> to return 20 parameters while the limit was set to 16.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/remote/remote_protocol.x | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index 8d17bad..810eeca 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -230,7 +230,7 @@ const REMOTE_NODE_MEMORY_PARAMETERS_MAX = 64;
>  const REMOTE_DOMAIN_MIGRATE_PARAM_LIST_MAX = 64;
>  
>  /* Upper limit on number of job stats */
> -const REMOTE_DOMAIN_JOB_STATS_MAX = 16;
> +const REMOTE_DOMAIN_JOB_STATS_MAX = 64;
>  
>  /* Upper limit on number of CPU models */
>  const REMOTE_CONNECT_CPU_MODELS_MAX = 8192;

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list